gh-115942: Add locked to several multiprocessing locks#115944
Merged
Conversation
Member
Author
|
@gpshead do you have an opinion about this? :) |
Member
Author
|
friendly ping @gpshead |
mpage
reviewed
Jun 21, 2024
Co-authored-by: mpage <mpage@cs.stanford.edu>
vstinner
reviewed
Mar 13, 2025
Member
|
FWIW this PR makes sense to me. |
Member
Author
|
Ok, then I will add all the missing details. Thanks a lot! 👍 |
picnixz
reviewed
Mar 13, 2025
vstinner
reviewed
Apr 1, 2025
vstinner
left a comment
Member
There was a problem hiding this comment.
Please add tests on threading.RLock.locked().
picnixz
reviewed
Apr 1, 2025
picnixz
left a comment
Member
There was a problem hiding this comment.
Just some rewording. Otherwise, once tests requested by Victor are added, LGTM.
Member
Author
picnixz
approved these changes
Apr 1, 2025
vstinner
reviewed
Apr 1, 2025
hugovk
reviewed
Apr 7, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gpshead
approved these changes
Apr 8, 2025
gpshead
left a comment
Member
There was a problem hiding this comment.
I wish I could object to this being a locked() method instead of a .locked property... but this is matching an existing ancient API on purpose so... LGTM.
Member
Author
|
Thanks everyone! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
AcquirerProxyobject has no attributelocked#115942